- 
                Notifications
    You must be signed in to change notification settings 
- Fork 929
oshmem/fortran: fix warning mesages #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @karasevb Github pro tip: enclose multi-line verbatim blocks with 3 tick marks. E.g.: If you're putting code in the verbatim block, you can even tell Github to do syntax hilighting -- see https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#code-and-syntax-highlighting. | 
| @rhc54 please check | 
| Problem was introduced in #1867 | 
930f404    to
    30a704e      
    Compare
  
    | @jladd-mlnx @miked-mellanox @hpcraink please, review. | 
| Test FAILed. | 
| What is the  | 
| bot:mellanox:retest | 
    
      
        1 similar comment
      
    
  
    | bot:mellanox:retest | 
30a704e    to
    cf6fe0b      
    Compare
  
    | Test FAILed. | 
| @jsquyres | 
| Test FAILed. | 
| Is this targeting 2.0.1 release? | 
| Depends on whether #1867 was PR'd to release or not. I'll check later. | 
| @karasevb Cool; thanks for the explanation. | 
| @hppritcha as it is for now #1867 wasn't cherry-picked to release: I didn't found the PR pending. If we do want that @karasevb can take care of that for both PR's. I guess we want that for consistency. @jladd-mlnx @miked-mellanox what do you think? | 
| bot:mellanox:retest | 
| @artpol84 - agree, better have in sync for consistency. | 
| Ok @karasevb will PR both of them once this is merged. | 
| bot:mellanox:retest | 
| checking the lanl bot | 
| bot:mellanox:retest | 
| Bot:retest | 
cf6fe0b    to
    6237d04      
    Compare
  
    | @igor-ivanov please review | 
| shmem_put() and shmem_get()  are part of old API that is supported to avoid issue with old applications. both functions should operate with long type. Change looks reasonable. Please consider correct formatting (you need to use spaces instead of tab). | 
| @igor-ivanov thank you! | 
6237d04    to
    fa448c3      
    Compare
  
    1dab61d    to
    033b2ca      
    Compare
  
    033b2ca    to
    49b6709      
    Compare
  
    
fix warning:
Please review this PR